Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EdgeX 3.0] Provision Watcher model improvement #772

Closed
cloudxxx8 opened this issue Nov 30, 2022 · 2 comments · Fixed by #803
Closed

[EdgeX 3.0] Provision Watcher model improvement #772

cloudxxx8 opened this issue Nov 30, 2022 · 2 comments · Fixed by #803
Assignees
@judehung
Labels
enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-metadata

Description [REQUIRED]

This is issue is opened for discussing the Provision Watcher model improvment in v3.0.

Describe the solution you'd like

The first suggestion is to modify type of the Identifiers to map[string][]string, which is the same as the BlockingIdentifiers
@cloudxxx8 cloudxxx8 added the enhancement New feature or request label Nov 30, 2022
@cloudxxx8 cloudxxx8 moved this to New Issues in Technical WG Nov 30, 2022
@cloudxxx8
Copy link
Member Author

Another suggestion is to add an extendable field in this object:
Properties map[string]interface
For example, the Device Service can support DeviceNameTemplate to allow users to define the generated device name.

@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Technical WG Dec 7, 2022
@cloudxxx8 cloudxxx8 assigned judehung and jinlinGuan and unassigned judehung Feb 8, 2023
@cloudxxx8 cloudxxx8 assigned judehung and unassigned jinlinGuan Feb 15, 2023
@judehung
Copy link
Member

Describe the solution you'd like

The first suggestion is to modify type of the Identifiers to map[string][]string, which is the same as the BlockingIdentifiers

For the type change on PW's Identifiers, we will address it in #592. For this #772, we will simply add an extendable field Properties map[string]any into ProvisionWatcher dto/model.

judehung added a commit to judehung/go-mod-core-contracts that referenced this issue Feb 17, 2023
@judehung
feat: Add new Properties field to ProvisionWatcher DTO and Model
4695302 
Add an extendable field into ProvisionWatcher DTO and Model: Properties map[string]any
This is useful when certain device services requires extra information from ProvisionWatcher.  For example, assume a device service would like to generate the device name in certain format during auto discovery, the user can define a property "DeviceNameTemplate" with value as the template of device name in the ProvisionWatcher, so that the device service can pick up such property to generate the device name.

fixes edgexfoundry#772

Signed-off-by: Jude Hung <[email protected]>
@judehung judehung mentioned this issue Feb 17, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Release Backlog to Minnesota Done in Technical WG Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judehung judehung

Labels
enhancement New feature or request
Projects
Technical WG
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add new Properties field to ProvisionWatcher DTO and Model judehung/go-mod-core-contracts
3 participants
@cloudxxx8 @judehung @jinlinGuan