Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create client library for support-notifications #626

Merged
merged 2 commits into from
May 31, 2021

Conversation

weichou1229
Copy link
Member

Close #573

Signed-off-by: weichou [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #573

What is the new behavior?

Create clients for Subscription, Notification, and Transmission APIs

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #626 (b6c53fd) into master (d9f4bb2) will increase coverage by 0.54%.
The diff coverage is 69.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   55.95%   56.49%   +0.54%     
==========================================
  Files         131      134       +3     
  Lines        3937     4101     +164     
==========================================
+ Hits         2203     2317     +114     
- Misses       1495     1520      +25     
- Partials      239      264      +25     
Impacted Files Coverage Δ
v2/clients/http/notification.go 68.57% <68.57%> (ø)
v2/clients/http/subscription.go 68.62% <68.62%> (ø)
v2/clients/http/transmission.go 72.09% <72.09%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f4bb2...b6c53fd. Read the comment docs.

Create clients for Subscription, Notification, and Transmission APIs

Close edgexfoundry#573

Signed-off-by: weichou <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit ee4e77d into edgexfoundry:master May 31, 2021
@weichou1229 weichou1229 deleted the issue-573 branch May 31, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2] Create client library for support-notifications
4 participants