feat: Rename the Notification sending func

Close #573 Signed-off-by: weichou <[email protected]>
edgexfoundry · May 31, 2021 · e64eb79 · e64eb79
1 parent ee842a9
commit e64eb79
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 31 deletions.
diff --git a/v2/clients/http/notification.go b/v2/clients/http/notification.go
@@ -31,8 +31,8 @@ func NewNotificationClient(baseUrl string) interfaces.NotificationClient {
 	}
 }
 
-// Add adds new notifications.
-func (client *NotificationClient) Add(ctx context.Context, reqs []requests.AddNotificationRequest) (res []common.BaseWithIdResponse, err errors.EdgeX) {
+// SendNotification sends new notifications.
+func (client *NotificationClient) SendNotification(ctx context.Context, reqs []requests.AddNotificationRequest) (res []common.BaseWithIdResponse, err errors.EdgeX) {
 	err = utils.PostRequestWithRawData(ctx, &res, client.baseUrl+v2.ApiNotificationRoute, reqs)
 	if err != nil {
 		return res, errors.NewCommonEdgeXWrapper(err)

diff --git a/v2/clients/http/notification_test.go b/v2/clients/http/notification_test.go
@@ -34,11 +34,11 @@ func addNotificationRequest() requests.AddNotificationRequest {
 	)
 }
 
-func TestNotificationClient_Add(t *testing.T) {
+func TestNotificationClient_SendNotification(t *testing.T) {
 	ts := newTestServer(http.MethodPost, v2.ApiNotificationRoute, []common.BaseWithIdResponse{})
 	defer ts.Close()
 	client := NewNotificationClient(ts.URL)
-	res, err := client.Add(context.Background(), []requests.AddNotificationRequest{addNotificationRequest()})
+	res, err := client.SendNotification(context.Background(), []requests.AddNotificationRequest{addNotificationRequest()})
 	require.NoError(t, err)
 	require.IsType(t, []common.BaseWithIdResponse{}, res)
 }

diff --git a/v2/clients/interfaces/mocks/NotificationClient.go b/v2/clients/interfaces/mocks/NotificationClient.go
diff --git a/v2/clients/interfaces/notification.go b/v2/clients/interfaces/notification.go
@@ -16,8 +16,8 @@ import (
 
 // NotificationClient defines the interface for interactions with the Notification endpoint on the EdgeX Foundry support-notifications service.
 type NotificationClient interface {
-	// Add adds new notifications.
-	Add(ctx context.Context, reqs []requests.AddNotificationRequest) ([]common.BaseWithIdResponse, errors.EdgeX)
+	// SendNotification sends new notifications.
+	SendNotification(ctx context.Context, reqs []requests.AddNotificationRequest) ([]common.BaseWithIdResponse, errors.EdgeX)
 	// NotificationById query notification by id.
 	NotificationById(ctx context.Context, id string) (responses.NotificationResponse, errors.EdgeX)
 	// DeleteNotificationById deletes a notification by id.