Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Implement the re-designed device profile model #539

Closed
weichou1229 opened this issue Mar 9, 2021 · 0 comments · Fixed by #540
Closed

[V2] Implement the re-designed device profile model #539

weichou1229 opened this issue Mar 9, 2021 · 0 comments · Fixed by #540

Comments

@weichou1229
Copy link
Member

weichou1229 commented Mar 9, 2021

  • coreCommands is dropped from the device profile

  • An attribute (isHidden: true/false with false the default) will be added to the deviceResource and deviceCommand elements to indicate the visibility of any resource or command via Core Command (effectively replacing the coreCommands section of the profile).

  • On deviceCommands, we are removing the get/set section.

  • On deviceCommands, we are renaming parameter to defaultValue

  • On deviceCommands, we will use single resourceOperations to specify selected deviceResources on deviceCommands.

  • On deviceCommands, add a readWrite indicator to show whether get or set for the deviceCommand is allowed. The readWrite property can be more restrictive than the associated readWrite property for the deviceResource but it cannot reverse or relax the restriction of the deviceResource (example, make a deviceCommand ‘R’ when the deviceResource is ‘W’ or make the deviceCommand ‘RW’ when the deviceResource is ‘W’). From a schema perspective, the readWrite indicator will align to what is already the readWrite property on deviceResource.

  • A sourceName will be added to Event DTO to specify the deviceResource or deviceCommand. The sourceName property will also be used in AutoEvents.

weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 10, 2021
- coreCommands is dropped from the device profile

- An attribute (isHidden: true/false with false the default) will be added to the deviceResource and deviceCommand elements to indicate the visibility of any resource or command via Core Command (effectively replacing the coreCommands section of the profile).

- On deviceCommands, we are removing the get/set section.

- On deviceCommands, we are renaming parameter to defaultValue

- On deviceCommands, we will use single resourceOperations to specify selected deviceResources on deviceCommands.

- On deviceCommands, add a **readWrite** indicator to show whether get or set for the deviceCommand is allowed.  The readWrite property can be more restrictive than the associated readWrite property for the deviceResource but it cannot reverse or relax the restriction of the deviceResource (example, make a deviceCommand ‘R’ when the deviceResource is ‘W’ or make the deviceCommand ‘RW’ when the deviceResource is ‘W’). From a schema perspective, the readWrite indicator will **align to what is already the readWrite property on deviceResource**.

Close edgexfoundry#539

Signed-off-by: weichou <[email protected]>
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 10, 2021
- coreCommands is dropped from the device profile

- An attribute (isHidden: true/false with false the default) will be added to the deviceResource and deviceCommand elements to indicate the visibility of any resource or command via Core Command (effectively replacing the coreCommands section of the profile).

- On deviceCommands, we are removing the get/set section.

- On deviceCommands, we are renaming parameter to defaultValue

- On deviceCommands, we will use single resourceOperations to specify selected deviceResources on deviceCommands.

- On deviceCommands, add a **readWrite** indicator to show whether get or set for the deviceCommand is allowed.  The readWrite property can be more restrictive than the associated readWrite property for the deviceResource but it cannot reverse or relax the restriction of the deviceResource (example, make a deviceCommand ‘R’ when the deviceResource is ‘W’ or make the deviceCommand ‘RW’ when the deviceResource is ‘W’). From a schema perspective, the readWrite indicator will **align to what is already the readWrite property on deviceResource**.

Close edgexfoundry#539

Signed-off-by: weichou <[email protected]>
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 11, 2021
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Mar 11, 2021
cloudxxx8 pushed a commit that referenced this issue Mar 11, 2021
* feat: Implement the re-designed device profile model

- coreCommands is dropped from the device profile

- An attribute (isHidden: true/false with false the default) will be added to the deviceResource and deviceCommand elements to indicate the visibility of any resource or command via Core Command (effectively replacing the coreCommands section of the profile).

- On deviceCommands, we are removing the get/set section.

- On deviceCommands, we are renaming parameter to defaultValue

- On deviceCommands, we will use single resourceOperations to specify selected deviceResources on deviceCommands.

- On deviceCommands, add a **readWrite** indicator to show whether get or set for the deviceCommand is allowed.  The readWrite property can be more restrictive than the associated readWrite property for the deviceResource but it cannot reverse or relax the restriction of the deviceResource (example, make a deviceCommand ‘R’ when the deviceResource is ‘W’ or make the deviceCommand ‘RW’ when the deviceResource is ‘W’). From a schema perspective, the readWrite indicator will **align to what is already the readWrite property on deviceResource**.

Close #539

Signed-off-by: weichou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant