Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance the auth hook func to support external JWT #811

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lindseysimple
Copy link
Contributor

Resolves #810. Enhance the auth middleware func to support external JWT verifcation.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Resolves edgexfoundry#810. Enhance the auth middleware func to support external JWT verifcation.

Signed-off-by: Lindsey Cheng <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 48 lines in your changes missing coverage. Please review.

Project coverage is 46.37%. Comparing base (48a6707) to head (1da7d09).

Files with missing lines Patch % Lines
bootstrap/handlers/auth_middleware.go 0.00% 30 Missing ⚠️
bootstrap/handlers/headers/key.go 76.47% 11 Missing and 1 partial ⚠️
bootstrap/container/clients.go 50.00% 1 Missing and 1 partial ⚠️
bootstrap/handlers/auth_func.go 0.00% 2 Missing ⚠️
bootstrap/handlers/headers/jwt.go 93.75% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   45.80%   46.37%   +0.57%     
==========================================
  Files          59       61       +2     
  Lines        3524     3631     +107     
==========================================
+ Hits         1614     1684      +70     
- Misses       1791     1825      +34     
- Partials      119      122       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the authentication middleware function to support external JWT
2 participants