Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security Consul metrics #383

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

vli11
Copy link
Contributor

@vli11 vli11 commented Oct 19, 2022

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@vli11 vli11 requested a review from lenny-goodell October 19, 2022 00:03
@vli11 vli11 self-assigned this Oct 19, 2022
@lenny-goodell
Copy link
Member

PR tile should be the same as the commit message. This will fix the failing Semantic PR.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vli11 vli11 changed the title Metrics feat: add security Consul metrics Oct 19, 2022
@lenny-goodell lenny-goodell merged commit a43e448 into edgexfoundry:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants