Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Added support for listing secrets #348 #369

Merged
merged 10 commits into from
Sep 19, 2022

Conversation

drkfmorton
Copy link
Contributor

@drkfmorton drkfmorton commented Sep 7, 2022

Signed-off-by: Kyle Morton [email protected]

Fixes #348

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@drkfmorton
Copy link
Contributor Author

Starting this PR while I finish testing

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #369 (c5d297d) into main (8193814) will increase coverage by 0.05%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   58.22%   58.28%   +0.05%     
==========================================
  Files          24       24              
  Lines        1575     1594      +19     
==========================================
+ Hits          917      929      +12     
- Misses        620      624       +4     
- Partials       38       41       +3     
Impacted Files Coverage Δ
bootstrap/secret/secure.go 78.57% <60.00%> (-1.18%) ⬇️
bootstrap/secret/insecure.go 79.66% <66.66%> (-2.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@drkfmorton drkfmorton marked this pull request as ready for review September 8, 2022 17:58
Kyle Morton added 2 commits September 12, 2022 14:05
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
bootstrap/interfaces/secret.go Outdated Show resolved Hide resolved
Signed-off-by: Kyle Morton <[email protected]>
@drkfmorton
Copy link
Contributor Author

Need to update go.mod with the latest changes from go-mod-secrets.

bootstrap/secret/insecure_test.go Outdated Show resolved Hide resolved
bootstrap/secret/insecure_test.go Outdated Show resolved Hide resolved
bootstrap/secret/insecure_test.go Outdated Show resolved Hide resolved
bootstrap/secret/secure_test.go Outdated Show resolved Hide resolved
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 3935c8c into edgexfoundry:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to list all secret path names from the SecretProvider
4 participants