-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Added support for listing secrets #348 #369
Conversation
Signed-off-by: Kyle Morton <[email protected]>
Starting this PR while I finish testing |
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 58.22% 58.28% +0.05%
==========================================
Files 24 24
Lines 1575 1594 +19
==========================================
+ Hits 917 929 +12
- Misses 620 624 +4
- Partials 38 41 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Need to update go.mod with the latest changes from go-mod-secrets. |
Signed-off-by: Kyle Morton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kyle Morton [email protected]
Fixes #348
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)