Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add common Messaging bootstrap handler #360

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

lenny-goodell
Copy link
Member

This is needed as other core/support service start using the MessageBus
for Service Metrics and System Events.

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A for internal code

Testing Instructions

Use this branch in edgex-go
Modify core -data to:

  • Use new handler from this branch
  • Add setting MessageQueue in result returned by GetBootstrap()
  • Build an run Core Data.
  • Verify runs fine and receives data from the MessageBus

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell requested a review from cloudxxx8 July 21, 2022 00:13
@lenny-goodell lenny-goodell added enhancement New feature or request 3-high priority denoting release-blocking issues tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds labels Jul 21, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #360 (15107ca) into main (816d4c9) will increase coverage by 1.23%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   60.28%   61.52%   +1.23%     
==========================================
  Files          22       23       +1     
  Lines        1380     1458      +78     
==========================================
+ Hits          832      897      +65     
- Misses        514      523       +9     
- Partials       34       38       +4     
Impacted Files Coverage Δ
config/types.go 35.29% <ø> (ø)
bootstrap/handlers/messaging.go 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816d4c9...15107ca. Read the comment docs.

bootstrap/handlers/messaging.go Outdated Show resolved Hide resolved
bootstrap/handlers/messaging.go Outdated Show resolved Hide resolved
This is needed as other core/support service start using the MessageBus
for Service Metrics and System Events.

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell requested a review from cloudxxx8 July 21, 2022 18:47
@lenny-goodell
Copy link
Member Author

@cloudxxx8 , if you approve PR, please merge.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit aaf2123 into edgexfoundry:main Jul 22, 2022
@lenny-goodell lenny-goodell deleted the messaging-handler branch July 25, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants