Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to disable metric reporting with interval of 0 #328

Merged

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

use branch in Core Data
Build and run Core Data from command line with DEBIG logging
Set interval to 0
Verify logs have following:

0 specified for metrics reporting interval. Setting to max duration to effectively disable reporting.

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #328 (144bd84) into main (a90d46a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   60.14%   60.17%   +0.02%     
==========================================
  Files          22       22              
  Lines        1360     1366       +6     
==========================================
+ Hits          818      822       +4     
- Misses        510      511       +1     
- Partials       32       33       +1     
Impacted Files Coverage Δ
bootstrap/config/config.go 0.00% <0.00%> (ø)
bootstrap/handlers/metrics.go 86.36% <0.00%> (-13.64%) ⬇️
bootstrap/metrics/manager.go 91.17% <0.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90d46a...144bd84. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 010839c into edgexfoundry:main Apr 26, 2022
@lenny-goodell lenny-goodell deleted the 0sec-interval-disables branch April 26, 2022 00:11
jinlinGuan pushed a commit to IOTechSystems/go-mod-bootstrap that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants