refactor: Secret Provider for all services #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored Secret Provider per ADR so it can be used by all services (core, support, App & Device) closes #126 Signed-off-by: lenny <[email protected]>
lenny-goodell
requested review from
adam-intel,
bnevis-i,
eno-intel,
jim-wang-intel,
iain-anderson and
tonyespy
|
In Draft until Secret Provider ADR is approved and dependent PR merged. |
6 tasks
Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
secret-provider
branch
2 times, most recently
from
eb10c7c to
e3ea31a
Compare
lenny-goodell
force-pushed
the
secret-provider
branch
from
e3ea31a to
ba729e3
Compare
…mplementations Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
secret-provider
branch
from
ba729e3 to
a8a073e
Compare
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 58.07% 55.97% -2.11%
==========================================
Files 8 14 +6
Lines 458 661 +203
==========================================
+ Hits 266 370 +104
- Misses 183 277 +94
- Partials 9 14 +5
Continue to review full report at Codecov.
|
jim-wang-intel
requested changes
Dec 15, 2020
12 tasks
Signed-off-by: lenny <[email protected]>
jim-wang-intel
approved these changes
Dec 15, 2020
cloudxxx8
requested changes
Dec 18, 2020
Reworked container DIC get functions Swith to use RWMutex for secrest cache. Signed-off-by: lenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.
What is the current behavior?
Secret provider only used by core/support services. App service has own implementation. Device services don't have one.
Issue Number: #126
This PR is dependent on edgexfoundry/go-mod-secrets#71
What is the new behavior?
Refactored Secret Provider per ADR so it can be used by all services (core, support, App & Device)
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information