refactor: Use new enhanced SecretProvider #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
SecretProvider
branch
from
4756642 to
03eea1b
Compare
lenny-goodell
force-pushed
the
SecretProvider
branch
8 times, most recently
from
37b4b3d to
00da2f7
Compare
closes edgexfoundry#2888 Signed-off-by: Lenny Goodell <[email protected]>
lenny-goodell
force-pushed
the
SecretProvider
branch
2 times, most recently
from
a1147e7 to
9460977
Compare
lenny-goodell
force-pushed
the
SecretProvider
branch
from
9460977 to
64cc1e3
Compare
Signed-off-by: Lenny Goodell <[email protected]>
lenny-goodell
force-pushed
the
SecretProvider
branch
from
64cc1e3 to
94409b7
Compare
Signed-off-by: Lenny Goodell <[email protected]>
lenny-goodell
force-pushed
the
SecretProvider
branch
from
7237c48 to
df695e1
Compare
This new version was brought in by testify v1.6.1 Signed-off-by: Lenny Goodell <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2942 +/- ##
==========================================
- Coverage 39.99% 39.99% -0.01%
==========================================
Files 157 157
Lines 13558 13559 +1
==========================================
Hits 5423 5423
- Misses 7816 7817 +1
Partials 319 319
Continue to review full report at Codecov.
|
cloudxxx8
reviewed
Dec 21, 2020
Signed-off-by: Lenny Goodell <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
jim-wang-intel
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Currently use SecretProvider from go-mod-bootstrap that is only for edgex-go services
Issue Number: #2888
What is the new behavior?
Use new reworked/enhanced SecretProvider from go-mod-bootstrap that is for all services
Includes new InsecureSecrets capability to pull from configuration when Vault is not being used.
This PR is dependent on the following PRs:
edgexfoundry/go-mod-bootstrap#134
edgexfoundry/go-mod-secrets#71
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information