Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove tests for /metrics endpoint #766

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

lenny-goodell
Copy link
Member

This enpoint is being removed in edgexfoundry/edgex-go#4311 and future PRs for App and Device SDKs

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

This enpoint is being removed in edgexfoundry/edgex-go#4311 and future PRs for App and Device SDKs

Signed-off-by: Leonard Goodell <[email protected]>
Copy link
Contributor

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherrycl cherrycl merged commit 5a52662 into edgexfoundry:main Jan 31, 2023
@lenny-goodell lenny-goodell deleted the no-metrics-endpoints branch June 12, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants