Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update status code to 400 when sending device profile with invalid units #711

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

cherrycl
Copy link
Contributor

Fix #710

Signed-off-by: Cherry Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@cherrycl cherrycl requested a review from jumpingliu September 27, 2022 03:23
Copy link
Contributor

@jumpingliu jumpingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumpingliu jumpingliu merged commit a63327f into edgexfoundry:main Sep 27, 2022
@cherrycl cherrycl deleted the issue-710 branch September 27, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should return 400, when sending post device profile/ resource with invalid units
2 participants