Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement tests for Units of Measure(UoM) #703

Merged
merged 1 commit into from
Sep 2, 2022
Merged

feat: Implement tests for Units of Measure(UoM) #703

merged 1 commit into from
Sep 2, 2022

Conversation

cherrycl
Copy link
Contributor

@cherrycl cherrycl commented Aug 30, 2022 •
edited
Loading

  1. Implement tests for Units of Measure(UoM)
  2. Remove tests on PATCH device resource, device resource can't update units.
  3. Modify some keywords

Fix #684

Signed-off-by: Cherry Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@cherrycl
Copy link
Contributor Author

Raised issue edgexfoundry/edgex-go#4140 for test ProfileResourcePOST003

@cherrycl cherrycl force-pushed the issue-684-implement branch from d6f0221 to 8350815 Compare September 1, 2022 01:27
@cherrycl cherrycl requested a review from jinlinGuan September 1, 2022 01:41
jumpingliu
jumpingliu approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@jumpingliu jumpingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jinlinGuan
jinlinGuan approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlinGuan jinlinGuan merged commit a8729ca into edgexfoundry:main Sep 2, 2022
@cherrycl cherrycl deleted the issue-684-implement branch September 7, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumpingliu jumpingliu jumpingliu approved these changes

@jinlinGuan jinlinGuan jinlinGuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the automation tests for UoM feature
3 participants
@cherrycl @jinlinGuan @jumpingliu