Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Modbus scalability testing #178

Merged
merged 1 commit into from
Dec 3, 2020
Merged

feat: Add Modbus scalability testing #178

merged 1 commit into from
Dec 3, 2020

Conversation

weichou1229
Copy link
Member

  • Add testing script and modify the docker-compose file to run the Modbus scalability testing.
  • Write the document docs/modbus-scalability-test.md

Fix #137

@weichou1229 weichou1229 force-pushed the issue-137 branch 7 times, most recently from 6a34c89 to 4e866c0 Compare September 8, 2020 07:00
cherrycl
cherrycl approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jinlinGuan
jinlinGuan approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichou1229 weichou1229 force-pushed the issue-137 branch 2 times, most recently from f200af5 to 3d0c92a Compare September 18, 2020 12:51
@weichou1229 weichou1229 force-pushed the issue-137 branch 5 times, most recently from 720c4ab to 4a9545f Compare November 4, 2020 07:10
@weichou1229 weichou1229 force-pushed the issue-137 branch 2 times, most recently from 0507e88 to 7be2a17 Compare November 10, 2020 13:23
@weichou1229 weichou1229 force-pushed the issue-137 branch 2 times, most recently from 54f6075 to 41afe01 Compare November 22, 2020 16:02
@cloudxxx8
Copy link
Member

this issue edgexfoundry/go-mod-messaging#76 would impact this test

@weichou1229 weichou1229 mentioned this pull request Nov 23, 2020
Closed
@weichou1229 weichou1229 force-pushed the issue-137 branch 3 times, most recently from 384e1c5 to 08e8329 Compare November 25, 2020 03:37
@weichou1229 weichou1229 force-pushed the issue-137 branch 3 times, most recently from 0ca0740 to d88c2bc Compare November 27, 2020 05:06
cherrycl
cherrycl reviewed Nov 30, 2020
View reviewed changes
TAF/utils/scripts/docker/docker-compose-end-to-end.yaml
@@ -117,3 +117,28 @@
- data
networks:
- edgex-network

scalability-test-mqtt-export:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to add the depends_on.

depends_on:
      - consul
      - data

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

TAF/utils/scripts/docker/start-services.sh Outdated
CONF_DIR=/custom-config
docker run --rm -v ${WORK_DIR}:${WORK_DIR} -w ${WORK_DIR} -v /var/run/docker.sock:/var/run/docker.sock \
--env WORK_DIR=${WORK_DIR} --env PROFILE=${PROFILE} --security-opt label:disable \
${COMPOSE_IMAGE} -f "${WORK_DIR}/TAF/utils/scripts/docker/docker-compose.yaml" start $*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do the scripts use this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the redundant script.

@weichou1229 weichou1229 requested a review from cherrycl November 30, 2020 03:06
jinlinGuan
jinlinGuan approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichou1229 weichou1229 force-pushed the issue-137 branch 2 times, most recently from 5034927 to 8c5ccd2 Compare December 2, 2020 13:31
@weichou1229
feat: Add Modbus scalability testing
b80dbeb 
Add testing script and modify the docker-compose file to run the Modbus scalability testing.

Signed-off-by: weichou <[email protected]>
@weichou1229 weichou1229 force-pushed the issue-137 branch 2 times, most recently from 665b1d5 to f3b4910 Compare December 2, 2020 13:34
jinlinGuan
jinlinGuan approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlinGuan jinlinGuan merged commit 3eceabc into edgexfoundry:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlinGuan jinlinGuan jinlinGuan approved these changes

@cherrycl cherrycl Awaiting requested review from cherrycl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modbus scalability test
4 participants
@weichou1229 @cloudxxx8 @cherrycl @jinlinGuan