Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add key-related APIs in security-proxy-auth #5039

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lindseysimple
Copy link
Contributor

Resolves #5038. Add key-related APIs in security-proxy-auth to enable support for external JWT verification.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Resolves edgexfoundry#5038. Add key-related APIs in security-proxy-auth to enable support for external JWT verification.

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.50802% with 158 lines in your changes missing coverage. Please review.

Project coverage is 27.96%. Comparing base (0ef5369) to head (b41f93f).

Files with missing lines Patch % Lines
internal/security/proxyauth/application/key.go 0.00% 41 Missing ⚠️
internal/security/proxyauth/controller/key.go 0.00% 41 Missing ⚠️
internal/pkg/infrastructure/postgres/keystore.go 0.00% 31 Missing ⚠️
internal/pkg/utils/aes.go 67.44% 7 Missing and 7 partials ⚠️
internal/security/proxyauth/router.go 0.00% 7 Missing ⚠️
...ternal/security/proxyauth/controller/controller.go 0.00% 6 Missing ⚠️
internal/security/proxyauth/config/config.go 0.00% 4 Missing ⚠️
internal/security/proxyauth/utils/key.go 0.00% 4 Missing ⚠️
internal/security/proxyauth/container/database.go 0.00% 2 Missing ⚠️
internal/core/command/router.go 0.00% 1 Missing ⚠️
... and 7 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5039      +/-   ##
==========================================
- Coverage   28.05%   27.96%   -0.10%     
==========================================
  Files         243      251       +8     
  Lines       17602    17764     +162     
==========================================
+ Hits         4938     4967      +29     
- Misses      11536    11662     +126     
- Partials     1128     1135       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add key-related APIs in the security-proxy-auth service to enable support for external JWT verification
2 participants