Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Acknowledged field to support-notification to enhance the API #5034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jinlinGuan
Copy link
Contributor

  • GET /notification: Multiple conditions query
  • PUT /notification/acknowledge/ids/{ids}: Update the acknowledgement status of one or more notifications to true
  • PUT /notification/unacknowledge/ids/{ids}: Update the acknowledgement status of one or more notifications to false
  • DELETE /notification/ids/{ids}: Delete one or more notifications

close #5006

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

- GET /notification: Multiple conditions query
- PUT /notification/acknowledge/ids/{ids}: Update the acknowledgement status of one or more notifications to true
- PUT /notification/unacknowledge/ids/{ids}: Update the acknowledgement status of one or more notifications to false
- DELETE /notification/ids/{ids}: Delete one or more notifications

close edgexfoundry#5006

Signed-off-by: Ginny Guan <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.30435% with 464 lines in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (0ef5369) to head (fec1316).

Files with missing lines Patch % Lines
internal/pkg/infrastructure/redis/notification.go 0.00% 141 Missing ⚠️
...ations/infrastructure/interfaces/mocks/DBClient.go 26.61% 68 Missing and 34 partials ⚠️
...ternal/pkg/infrastructure/postgres/notification.go 0.00% 99 Missing ⚠️
internal/pkg/infrastructure/redis/client.go 0.00% 58 Missing ⚠️
.../support/notifications/application/notification.go 0.00% 44 Missing ⚠️
...port/notifications/controller/http/notification.go 84.09% 7 Missing and 7 partials ⚠️
internal/support/notifications/router.go 0.00% 4 Missing ⚠️
internal/pkg/infrastructure/postgres/sql.go 0.00% 1 Missing ⚠️
...ternal/pkg/infrastructure/postgres/transmission.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5034      +/-   ##
==========================================
- Coverage   28.05%   28.00%   -0.06%     
==========================================
  Files         243      243              
  Lines       17602    17975     +373     
==========================================
+ Hits         4938     5033      +95     
- Misses      11536    11788     +252     
- Partials     1128     1154      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Acknowledged field to support-notification to enhance the API
3 participants