Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: update module to v4 and replace vault with openbao #4982

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

jinlinGuan
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

BREAKING CHANGE: update go module to v4

Signed-off-by: Ginny Guan <[email protected]>
BREAKING CHANGE: replace Vault with OpenBao

Signed-off-by: Ginny Guan <[email protected]>
Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes missing coverage. Please review.

Project coverage is 28.98%. Comparing base (c89e7d4) to head (2fd20ad).

Files with missing lines Patch % Lines
internal/security/secretstore/init.go 22.22% 14 Missing ⚠️
internal/security/secretstore/main.go 0.00% 4 Missing ⚠️
.../security/config/command/proxy/shared/proxyuser.go 0.00% 3 Missing ⚠️
internal/security/secretstore/vmkencryption.go 50.00% 2 Missing ⚠️
internal/security/fileprovider/init.go 0.00% 1 Missing ⚠️
internal/security/proxyauth/init.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4982      +/-   ##
==========================================
- Coverage   29.35%   28.98%   -0.38%     
==========================================
  Files         249      249              
  Lines       18676    18536     -140     
==========================================
- Hits         5483     5372     -111     
+ Misses      11948    11945       -3     
+ Partials     1245     1219      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit c963200 into edgexfoundry:main Oct 28, 2024
6 checks passed
@jinlinGuan jinlinGuan deleted the v4-module branch October 28, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants