Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check offset, limit, totalCount before executing query #4975

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jinlinGuan
Copy link
Contributor

close #4948

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.80247% with 289 lines in your changes missing coverage. Please review.

Project coverage is 30.78%. Comparing base (82350b2) to head (b7d163c).

Files with missing lines Patch % Lines
internal/core/data/application/reading.go 33.80% 41 Missing and 6 partials ⚠️
.../cronscheduler/application/scheduleactionrecord.go 0.00% 39 Missing ⚠️
.../support/notifications/application/notification.go 0.00% 35 Missing ⚠️
...nternal/core/metadata/application/deviceprofile.go 0.00% 28 Missing ⚠️
.../support/notifications/application/subscription.go 0.00% 28 Missing ⚠️
.../support/notifications/application/transmission.go 0.00% 28 Missing ⚠️
internal/core/metadata/application/device.go 0.00% 21 Missing ⚠️
...rnal/core/metadata/application/provisionwatcher.go 0.00% 21 Missing ⚠️
internal/core/data/application/event.go 23.80% 15 Missing and 1 partial ⚠️
...rnal/pkg/infrastructure/postgres/device_profile.go 0.00% 9 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4975      +/-   ##
==========================================
- Coverage   31.81%   30.78%   -1.03%     
==========================================
  Files         265      266       +1     
  Lines       19484    19658     +174     
==========================================
- Hits         6199     6052     -147     
- Misses      11861    12276     +415     
+ Partials     1424     1330      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 6ace714 into edgexfoundry:main Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should return 416 when sending request with offset parameter and value is over than totalCount
3 participants