Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix delete transmission by age with Postgres #4973

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jinlinGuan
Copy link
Contributor

also upgrade go-mod-core-contracts to latest version

close #4965

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

also upgrade go-mod-core-contracts to latest version

close edgexfoundry#4965

Signed-off-by: Ginny Guan <[email protected]>
Copy link

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.80%. Comparing base (cae398a) to head (3517e8a).

Files with missing lines Patch % Lines
...ternal/pkg/infrastructure/postgres/transmission.go 0.00% 3 Missing ⚠️
internal/pkg/infrastructure/postgres/sql.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4973      +/-   ##
==========================================
- Coverage   31.81%   31.80%   -0.01%     
==========================================
  Files         265      265              
  Lines       19467    19470       +3     
==========================================
  Hits         6193     6193              
- Misses      11851    11854       +3     
  Partials     1423     1423              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit 0f2c1aa into edgexfoundry:main Oct 16, 2024
6 checks passed
@jinlinGuan jinlinGuan deleted the issue-4965 branch October 16, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete transmission by age doesn't work
3 participants