Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove old InsecureSecrets backward compatibility elements #4672

Merged

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Sep 5, 2023

Old elements were left in-place until all Device/App services got updated with the latest go-mod-bootstrap, which happened with the 3.0 release.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell requested a review from ejlee3 September 5, 2023 22:01
@lenny-goodell lenny-goodell added the tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds label Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lenny-goodell lenny-goodell added this to the Napa milestone Sep 5, 2023
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4672 (bec9b59) into main (488f23b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4672   +/-   ##
=======================================
  Coverage   41.84%   41.84%           
=======================================
  Files         105      105           
  Lines        9723     9723           
=======================================
  Hits         4069     4069           
  Misses       5308     5308           
  Partials      346      346           

@lenny-goodell lenny-goodell merged commit 5e4c173 into edgexfoundry:main Sep 5, 2023
@lenny-goodell lenny-goodell deleted the cleanup-common-config branch September 5, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants