Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix core-command swagger file #4631

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

vli11
Copy link
Contributor

@vli11 vli11 commented Aug 12, 2023

fixing core-command swagger file that has incorrect example and missing PUT parameters

Closes: #4629

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

following #4569 test instructions for fuzzing test, you will observe the fuzzing test coverage has increased for core-command after this fix.

New Dependency Instructions (If applicable)

fixing core-command swagger file that has incorrect example and missing PUT parameters

Closes: edgexfoundry#4629
Signed-off-by: Valina Li <[email protected]>
@vli11 vli11 added the bug Something isn't working label Aug 12, 2023
@vli11 vli11 self-assigned this Aug 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4631 (caa27c1) into main (3ee9d72) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4631   +/-   ##
=======================================
  Coverage   41.88%   41.88%           
=======================================
  Files         105      105           
  Lines        9702     9702           
=======================================
  Hits         4064     4064           
  Misses       5296     5296           
  Partials      342      342           

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit fe3620c into edgexfoundry:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core-command swagger file has incorrect example and missing PUT parameters
4 participants