Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snap): Update env file path for security bootstrapper services #4555

Merged
merged 1 commit into from
May 8, 2023

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented May 8, 2023

This PR fixes the issue of device/app services lacking the role to access Consul, which was caused by the edegxfoundry snap side in PR #4530. Please see details on the comments.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

The device/app services listed below have successfully passed snap testing against channel latest/edge/pr-4555:

  • device-mqtt
  • device-gpio
  • device-snmp
  • device-rfid-llrp
  • app-rfid-llrp
  • device-usb-camera
  • device-onvif-camera

New Dependency Instructions (If applicable)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #4555 (a11cadb) into main (ce5d240) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4555   +/-   ##
=======================================
  Coverage   41.52%   41.52%           
=======================================
  Files         106      106           
  Lines        9768     9768           
=======================================
  Hits         4056     4056           
  Misses       5366     5366           
  Partials      346      346           

@MonicaisHer MonicaisHer requested a review from farshidtz May 8, 2023 11:48
@MonicaisHer MonicaisHer marked this pull request as ready for review May 8, 2023 11:49
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and testing.

@farshidtz farshidtz merged commit 857beb7 into edgexfoundry:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants