Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Ignore all go-mods except go-mod-bootstrap #4547

Merged
merged 1 commit into from
May 3, 2023
Merged

build: Ignore all go-mods except go-mod-bootstrap #4547

merged 1 commit into from
May 3, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 3, 2023 •
edited
Loading

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lenny-goodell lenny-goodell added the ci issue_type denoting non-code changes such as testing or compilation label May 3, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone May 3, 2023
@lenny-goodell
Copy link
Member Author

recheck

cloudxxx8
cloudxxx8 approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 09c3ed2 into edgexfoundry:main May 3, 2023
@lenny-goodell lenny-goodell deleted the ignore-go-mods branch May 3, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

@jim-wang-intel jim-wang-intel Awaiting requested review from jim-wang-intel

Assignees
No one assigned
Labels
ci issue_type denoting non-code changes such as testing or compilation
Projects
Technical WG
Archived in project
Milestone
Minnesota
Development

Successfully merging this pull request may close these issues.
2 participants
@lenny-goodell @cloudxxx8