-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update spire #4521
build: update spire #4521
Conversation
Signed-off-by: Bill Mahoney <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4521 +/- ##
=======================================
Coverage 41.54% 41.54%
=======================================
Files 106 106
Lines 9764 9764
=======================================
Hits 4056 4056
Misses 5362 5362
Partials 346 346 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I modified the docker_base dockerfile to use 1.6.3, rebuilt the containers, and ran with "make run dev delayed-start ds-virtual" ds-virtual is crashing with the following log
Somehow this is related to the upgrade. |
Breaking change #4519 is interfering with testing. Will try to go to the version before this and test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backing out the /v3 change resolves the issues.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)