New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(snap): Remove external metadata sourcing #4453

Merged

farshidtz merged 1 commit into edgexfoundry:main from farshidtz:snap-local-metadata

Mar 16, 2023

Member

farshidtz commented Mar 16, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
I am not introducing a new dependency (add notes below if you are)
I have added unit tests for the new feature or bug fix (if not, why?)
I have fully tested (add details below) this the new feature or bug fix (if not, why?)
I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)


          refactor(snap): Remove external metadata sourcing

6b3b581

Signed-off-by: Farshid Tavakolizadeh <[email protected]>

farshidtz requested a review from MonicaisHer

March 16, 2023 09:37

sonarqubecloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.3% Duplication

MonicaisHer approved these changes

View reviewed changes

farshidtz merged commit fb374ba into edgexfoundry:main

farshidtz deleted the snap-local-metadata branch

March 16, 2023 12:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet