Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add retry when calling HasConfiguration to wait for Consul #4334

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell linked an issue Feb 7, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #4334 (d0b236c) into main (6d8f489) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4334   +/-   ##
=======================================
  Coverage   43.15%   43.15%           
=======================================
  Files         116      116           
  Lines       10664    10664           
=======================================
  Hits         4602     4602           
  Misses       5657     5657           
  Partials      405      405           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ejlee3
ejlee3 previously approved these changes Feb 7, 2023
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jim-wang-intel
jim-wang-intel previously approved these changes Feb 7, 2023
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit a5aecf7 into edgexfoundry:main Feb 7, 2023
@lenny-goodell lenny-goodell deleted the cc-wait-4-consul branch February 7, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common-Config service startup failed sometimes
4 participants