Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Replace SecretStore service config with default values and overrides #4291

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Jan 17, 2023

BREAKING CHANGE: SecretStore config no longer in service configuration file. Changes must be done via use of environment variable overrides of default values

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

Run make docker from this branch
From compose builder run make run ds-virtual delayed-start dev
Verify all core/support services bootstrapped and running properly
Verify Device Virtual bootstrapped and running properly using runtime token provider. Log should contain:

level=INFO ts=2023-01-17T20:47:10.1690972Z app=device-virtual source=secret.go:173 msg="runtime token provider enabled"
level=INFO ts=2023-01-17T20:47:10.1691067Z app=device-virtual source=methods.go:138 msg="using Unix Domain Socket at unix:///tmp/edgex/secrets/spiffe/public/api.sock"
level=INFO ts=2023-01-17T20:47:10.2535458Z app=device-virtual source=methods.go:150 msg="workload got X509 source"

New Dependency Instructions (If applicable)

… overrides

BREAKING CHANGE: SecretStore config no longer in service configuration file. Changes must be done via use of environment variable overrides of default values

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell changed the title refactor! Replace SecretStore service config with default values and overrides refactor!: Replace SecretStore service config with default values and overrides Jan 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

@lenny-goodell lenny-goodell added tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds breaking-change labels Jan 17, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Jan 17, 2023
@lenny-goodell lenny-goodell requested a review from ejlee3 January 17, 2023 20:52
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lenny-goodell lenny-goodell merged commit 88ad770 into edgexfoundry:main Jan 17, 2023
@lenny-goodell lenny-goodell deleted the secret-store branch January 17, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants