-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(command): update core-command to support message bus access #4129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hahattan , look like you need to run |
sure dependent on the fininsh of edgexfoundry/go-mod-bootstrap#365 |
Right, for some reason I thought that got merged. I have approved and merged it. :-) |
Signed-off-by: Chris Hung <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dependent on edgexfoundry/go-mod-bootstrap#365
fix #4073
fix #4074
Signed-off-by: Chris Hung [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
core-command
from this branch withMESSAGEQUEUE_REQUIRED=true
environment variableNew Dependency Instructions (If applicable)