Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Missing error check #4100

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Conversation

drkfmorton
Copy link
Contributor

@drkfmorton drkfmorton commented Jul 21, 2022

Closes #4082

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Kyle Morton <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #4100 (31dee23) into main (66f7195) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4100      +/-   ##
==========================================
- Coverage   47.27%   47.26%   -0.02%     
==========================================
  Files         114      114              
  Lines        9850     9853       +3     
==========================================
  Hits         4657     4657              
- Misses       4805     4807       +2     
- Partials      388      389       +1     
Impacted Files Coverage Δ
internal/security/proxy/service.go 64.19% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f7195...31dee23. Read the comment docs.

@lenny-goodell
Copy link
Member

@drkfmorton , please complete the PR checklist. It is not optional.

internal/security/proxy/service.go Outdated Show resolved Hide resolved
@bnevis-i bnevis-i self-requested a review July 22, 2022 18:39
bnevis-i
bnevis-i previously approved these changes Jul 22, 2022
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming unit test passes.

@drkfmorton
Copy link
Contributor Author

Coverage of change:
image

@bnevis-i bnevis-i requested a review from lenny-goodell July 25, 2022 14:54
internal/security/proxy/service_test.go Outdated Show resolved Hide resolved
internal/security/proxy/service_test.go Outdated Show resolved Hide resolved
internal/security/proxy/service_test.go Show resolved Hide resolved
Signed-off-by: Kyle Morton <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit 062af8d into edgexfoundry:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error check at internal/security/proxy/service.go:322
4 participants