-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed Missing error check #4100
Conversation
Signed-off-by: Kyle Morton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4100 +/- ##
==========================================
- Coverage 47.27% 47.26% -0.02%
==========================================
Files 114 114
Lines 9850 9853 +3
==========================================
Hits 4657 4657
- Misses 4805 4807 +2
- Partials 388 389 +1
Continue to review full report at Codecov.
|
@drkfmorton , please complete the PR checklist. It is not optional. |
Signed-off-by: Kyle Morton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming unit test passes.
Signed-off-by: Kyle Morton <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #4082
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)