build(snap): upgrade device-virtual and app-service-config to 2.1 (Jakarta) #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## jakarta #4045 +/- ##
========================================
Coverage 45.84% 45.84%
========================================
Files 112 112
Lines 9655 9655
========================================
Hits 4426 4426
Misses 4845 4845
Partials 384 384 Continue to review full report at Codecov.
|
…gexfoundry#3831) * build(snap): upgrade device-virtual and app-service-config to 2.1 - update edgex-app-service-config to 2.1 - use stage keyword to filter `usr` file out, to solve the file conflict between `app-service-config` and `edgex-go` part - filter `external-mqtt-trigger` out - add inline comments - update device-virtual's git version - include files "Attribution.txt" and "LICENSE" Signed-off-by: Mengyi Wang <[email protected]> (cherry picked from commit f650799) Signed-off-by: Farshid Tavakolizadeh <[email protected]>
farshidtz
force-pushed
the
jakarta-snap-update-devicevirtual-asc-kuiper-redis
branch
from
8511ba1 to
cd470aa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MonicaisHer
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
@farshidtz Thanks, LGTM. I have ran checkboxtest jakarta suite, which contains this commit, against jakarta-2.1.1-snap branch. All passed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked commit from Kamakura PR:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)