Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(all): update Changelog for Kamakura #4010

Merged
merged 3 commits into from
May 10, 2022

Conversation

jpwhitemn
Copy link
Member

Signed-off-by: jpwhitemn [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) n/a
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) n/a
  • I have opened a PR for the related docs change (if not, why?) n/a

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #4010 (66f08e4) into main (ebb27bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4010   +/-   ##
=======================================
  Coverage   47.19%   47.19%           
=======================================
  Files         114      114           
  Lines        9831     9831           
=======================================
  Hits         4640     4640           
  Misses       4804     4804           
  Partials      387      387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb27bf...66f08e4. Read the comment docs.

Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpwhitemn Thanks for the changelog. Do you use a tool to generate the changelogs? It's missing some snap features in Kamakura and Jakarta.

E.g for Kamakura: #3986

Not sure if other scopes are affected too.

@jpwhitemn
Copy link
Member Author

@jpwhitemn Thanks for the changelog. Do you use a tool to generate the changelogs? It's missing some snap features in Kamakura and Jakarta.

E.g for Kamakura: #3986

Not sure if other scopes are affected too.

@bill-mahoney - can you get with Farshid on what items seem to be missing and whether these just need to be added by hand.
@farshidtz - we do have a tool that generates these and then we manually remove some of the items that would not be of concern to end users/adopters.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jpwhitemn jpwhitemn requested a review from farshidtz May 9, 2022 17:38
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpwhitemn for the updates.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit cd12ae5 into edgexfoundry:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants