Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Support Object value type in Reading #3742

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

weichou1229
Copy link
Member

Handle the object value for reading at Redis layer and modify doc for new value type

Closes #3679

Signed-off-by: bruce [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) add the object value type to swagger API

Testing Instructions

New Dependency Instructions (If applicable)

@weichou1229
Copy link
Member Author

This PR should hold until the core-contracts PR edgexfoundry/go-mod-core-contracts#666 merged

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Handle the object value for reading at Redis layer and modify doc for new value type

Closes edgexfoundry#3679

Signed-off-by: bruce <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@weichou1229
Copy link
Member Author

Rebased.

@lenny-goodell
Copy link
Member

recheck

2 similar comments
@cloudxxx8
Copy link
Member

recheck

@lenny-goodell
Copy link
Member

recheck

@codecov-commenter
Copy link

Codecov Report

Merging #3742 (94769bc) into main (d4ace7e) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   47.53%   47.51%   -0.02%     
==========================================
  Files         112      112              
  Lines        9132     9144      +12     
==========================================
+ Hits         4341     4345       +4     
- Misses       4412     4419       +7     
- Partials      379      380       +1     
Impacted Files Coverage Δ
internal/pkg/infrastructure/redis/reading.go 11.37% <33.33%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ace7e...94769bc. Read the comment docs.

@cloudxxx8 cloudxxx8 merged commit ad4e2ec into edgexfoundry:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support object value types in Reading
4 participants