-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data): Support Object value type in Reading #3742
Conversation
This PR should hold until the core-contracts PR edgexfoundry/go-mod-core-contracts#666 merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Handle the object value for reading at Redis layer and modify doc for new value type Closes edgexfoundry#3679 Signed-off-by: bruce <[email protected]>
db3e3a7
to
94769bc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Rebased. |
recheck |
2 similar comments
recheck |
recheck |
Codecov Report
@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 47.53% 47.51% -0.02%
==========================================
Files 112 112
Lines 9132 9144 +12
==========================================
+ Hits 4341 4345 +4
- Misses 4412 4419 +7
- Partials 379 380 +1
Continue to review full report at Codecov.
|
Handle the object value for reading at Redis layer and modify doc for new value type
Closes #3679
Signed-off-by: bruce [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)