feat(security): Create a Vault mgmt token for Consul Secrets API Operations #3192
+423
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
added
enhancement
jim-wang-intel
requested review from
beaufrusetta,
hutchic,
tonyespy,
cloudxxx8,
bnevis-i and
lenny-goodell
jim-wang-intel
force-pushed
the
create-special-vault-token
branch
2 times, most recently
from
123b826 to
5c6281c
Compare
lenny-goodell
requested changes
Feb 25, 2021
internal/security/secretstore/tokenfilewriter/tokenfilewriter.go
Outdated
Show resolved
Hide resolved
internal/security/secretstore/tokenfilewriter/tokenfilewriter.go
Outdated
Show resolved
Hide resolved
internal/security/secretstore/tokenfilewriter/tokenfilewriter_test.go
Outdated
Show resolved
Hide resolved
bnevis-i
previously requested changes
Feb 25, 2021
internal/security/secretstore/tokenfilewriter/tokenfilewriter.go
Outdated
Show resolved
Hide resolved
internal/security/secretstore/tokenfilewriter/tokenfilewriter.go
Outdated
Show resolved
Hide resolved
internal/security/secretstore/tokenfilewriter/tokenfilewriter_test.go
Outdated
Show resolved
Hide resolved
jim-wang-intel
force-pushed
the
create-special-vault-token
branch
from
5c6281c to
8169d6f
Compare
Changes in secretstore-setup: - add token file writer implementation for creating and writing Vault's Consul secrets admin token - add Consul ACL feature flag "ENABLE_REGISTRY_ACL" - add configuration setting for ConsulSecretAdminTokenPath for specifying token file location - refactor TokenMaintenance to share code with token file writer's implementation Closes: edgexfoundry#3155 Signed-off-by: Jim Wang <[email protected]>
Address feedbacks on tokenfile writer Signed-off-by: Jim Wang <[email protected]>
lenny-goodell
requested changes
Feb 26, 2021
internal/security/secretstore/tokenfilewriter/tokenfilewriter_test.go
Outdated
Show resolved
Hide resolved
PR comments addressed Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
force-pushed
the
create-special-vault-token
branch
from
8169d6f to
ee855b8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Phase 1 Securing Consul stories: Create a Vault token to configure consul access
Changes in
secretstore-setup:"ENABLE_REGISTRY_ACL"ConsulSecretAdminTokenPathfor specifying token file locationCloses: #3155
Signed-off-by: Jim Wang [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
N/A
Issue Number: #3155
What is the new behavior?
New Vault token created for special purpose of management Consul Secrets APIs operations policy: configure access / create update roles later on. This token will be later used by Consul's bootstrapper.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information
To verify this locally, one can git clone this PR and build a dev version of
docker_secretstore_setupand then add the following environment variables to docker-compose file ofsecretstore-setup:so that the ACL feature is turned on. Run
make run devand then observe the following docker logs fromedgex-secretstore-setup:docker logs edgex-secretstore-setup | grep "edgex-consul/admin/token"And also list the file, too:
$ sudo ls -al /tmp/edgex/secrets/edgex-consul/admin/