Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly publish V2 Event DTO to MessageBus as JSON #2973

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

MessageEnvelope doesn't contain the V2 DTO marshaled as JSON and Content Type not set when CoreData V2 Add Event publishes to MessageBus

Issue Number: #2972

What is the new behavior?

MessageEnvelope contains V2 DTO marshaled as JSON & Content Type is set to JSON.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #2973 (5f146b4) into master (c8e0122) will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
+ Coverage   39.99%   40.01%   +0.01%     
==========================================
  Files         157      157              
  Lines       13559    13560       +1     
==========================================
+ Hits         5423     5426       +3     
+ Misses       7817     7815       -2     
  Partials      319      319              
Impacted Files Coverage Δ
internal/core/data/v2/application/event.go 69.72% <57.14%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e0122...5f146b4. Read the comment docs.

Copy link
Member

@jpwhitemn jpwhitemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 0334f8c into edgexfoundry:master Dec 29, 2020
@lenny-goodell lenny-goodell deleted the v2-publish branch December 29, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2 Data] Add Event publishes empty payload/content type to message bus
3 participants