-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow name field escape configurable #4674
Conversation
45fb286
to
f25f8a5
Compare
@weichou1229 , this is not a breaking change. It is the fix to the previous breaking change, correct. Please remove Breaking Change statement from the commit and PR. |
f25f8a5
to
2e47f21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending dependent PRs
@weichou1229 https://github.com/edgexfoundry/go-mod-bootstrap/tree/v3.1.0-dev.34 is ready |
@lenny-intel To upgrade the go-mod-core-contracts, how to use the external topic for core-command?
|
Right. Dang it, I forgot we left those in configuration. |
Use latest go-mod-bootstrap and you should be good. |
2e47f21
to
df42bd9
Compare
Add config and modify topic build logic to allow name field escape configurable. Close edgexfoundry#4673 Signed-off-by: bruce <[email protected]>
Upgrade go-mod-bootstrap and go-mod-core-contracts. Close edgexfoundry#4673 Signed-off-by: bruce <[email protected]>
df42bd9
to
650e734
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Upgraded the libs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
addressed the request changes
BREAKING CHANGE: Add config and modify topic build logic to allow name field escape configurable.
Close #4673
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)link to docs PR
Testing Instructions
Related PRs are opened, you can refer to #4673 (comment) and run services to verify the API.
New Dependency Instructions (If applicable)