Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snap): Remove device-virtual #4041

Merged

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Jun 1, 2022

This PR removes device-virtual for the following reasons:

  • This app is for development/demonstration purposes only and not needed in production. It shouldn’t be shipped by default. It will become a standalone snap.
  • The hardcoded versioning of the source inside the snap makes it hard to keep the edgex-go source compatible with device-virtual source. Upstream takes care of go vendor versioning but not snapcraft parts.
  • The build and hooks logic adds avoidable complexity to the core snap. Removing device-virtual reduces edgex snap size from 293M to 283M.

Signed-off-by: Mengyi Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) Update device-virtual part in edgexfoundry and ekuiper test suites canonical/edgex-snap-testing#62
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

TODO:

New Dependency Instructions (If applicable)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MonicaisHer
Copy link
Contributor Author

snap test will pass after the update edgexfoundry test suite PR has been merged.

@MonicaisHer MonicaisHer marked this pull request as ready for review June 2, 2022 13:37
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

Tested together with edgexfoundry/device-virtual-go#287 and it works as expected.

@farshidtz farshidtz merged commit fed831e into edgexfoundry:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants