-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snap): Add snap packaging #287
feat(snap): Add snap packaging #287
Conversation
Signed-off-by: Mengyi Wang <[email protected]>
Signed-off-by: Mengyi Wang <[email protected]>
a3a9a1b
to
a266ebd
Compare
The Jenkins will be able to build snap after the metadata PR has been merged: canonical/edgex-snap-metadata#13 |
Signed-off-by: Mengyi Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 58.60% 58.60%
=======================================
Files 13 13
Lines 860 860
=======================================
Hits 504 504
Misses 312 312
Partials 44 44 Continue to review full report at Codecov.
|
@farshidtz could you please review it? thanks! |
Signed-off-by: Mengyi Wang <[email protected]>
You can disable it since we have the tests as Github Actions. |
Signed-off-by: Mengyi Wang <[email protected]>
Signed-off-by: Mengyi Wang <[email protected]>
Signed-off-by: Mengyi Wang <[email protected]>
ea4df9f
to
253bc95
Compare
Signed-off-by: Mengyi Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works as expected.
Signed-off-by: Mengyi Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lenny-intel could you please merge this PR. It has been reviewed but we don't have the committer rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review is approved by @farshidtz
edgexfoundry/edgex-go#4041 moves device-virtual out of edgexfoundry snap and this PR makes it a standalone snap.
Signed-off-by: Mengyi Wang [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Todo
sudo snap install edgex-device-virtual --channel=edge/pr287
New Dependency Instructions (If applicable)