Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snap): Add snap packaging #287

Merged

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Jun 1, 2022

edgexfoundry/edgex-go#4041 moves device-virtual out of edgexfoundry snap and this PR makes it a standalone snap.

Signed-off-by: Mengyi Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

  1. Install and setup:
# install the pre-built snap for this PR
sudo snap install edgex-device-virtual --channel=edge/pr287

# install platform
snap install edgexfoundry

# connect secret token
snap connect edgexfoundry:edgex-secretstore-token edgex-device-virtual:edgex-secretstore-token
  1. Run the service:
sudo snap start edgex-device-virtual
  1. Check device-virtual's readings in edgex core data: http://localhost:59880/api/v2/reading/all

Todo

New Dependency Instructions (If applicable)

@MonicaisHer MonicaisHer force-pushed the EDGEX-445-add-snap-packaging branch from a3a9a1b to a266ebd Compare June 1, 2022 14:53
@MonicaisHer
Copy link
Contributor Author

The Jenkins will be able to build snap after the metadata PR has been merged: canonical/edgex-snap-metadata#13

Signed-off-by: Mengyi Wang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #287 (e414a0e) into main (9cab873) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          13       13           
  Lines         860      860           
=======================================
  Hits          504      504           
  Misses        312      312           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cab873...e414a0e. Read the comment docs.

@MonicaisHer MonicaisHer marked this pull request as ready for review June 2, 2022 13:08
@MonicaisHer
Copy link
Contributor Author

@farshidtz could you please review it? thanks!

Signed-off-by: Mengyi Wang <[email protected]>
@farshidtz
Copy link
Member

The Jenkins will be able to build snap after the metadata PR has been merged: canonical/edgex-snap-metadata#13

You can disable it since we have the tests as Github Actions.

@MonicaisHer MonicaisHer changed the title feat(snap): Add snap packaing feat(snap): Add snap packaging Jun 2, 2022
@MonicaisHer MonicaisHer requested a review from farshidtz June 3, 2022 07:20
@MonicaisHer MonicaisHer force-pushed the EDGEX-445-add-snap-packaging branch from ea4df9f to 253bc95 Compare June 3, 2022 09:04
@MonicaisHer MonicaisHer requested a review from farshidtz June 3, 2022 09:37
.github/workflows/snap.yaml Outdated Show resolved Hide resolved
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected.

snap/local/hooks/cmd/configure/configure.go Show resolved Hide resolved
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz
Copy link
Member

@lenny-intel could you please merge this PR. It has been reviewed but we don't have the committer rights.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review is approved by @farshidtz

@cloudxxx8 cloudxxx8 merged commit dce4ce0 into edgexfoundry:main Jun 7, 2022
@MonicaisHer MonicaisHer deleted the EDGEX-445-add-snap-packaging branch June 7, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants