Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): Disable device notification by default #3789

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Oct 31, 2021

Set Notifications.PostDeviceChanges to false by default in core-metadata, because support-notifications service is not always up.
Modify the logging level Warn when sending notifications failed.
Close #3768

Signed-off-by: Cloud Tsai [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

Set Notifications.PostDeviceChanges to false by default in core-metadata, because support-notifications service is not always up.
Modify the logging level Warn when sending notifications failed.
Close edgexfoundry#3768

Signed-off-by: Cloud Tsai <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #3789 (0eb2b22) into main (adab524) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3789   +/-   ##
=======================================
  Coverage   45.77%   45.77%           
=======================================
  Files         112      112           
  Lines        9640     9640           
=======================================
  Hits         4413     4413           
  Misses       4844     4844           
  Partials      383      383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adab524...0eb2b22. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit c5f5ac1 into edgexfoundry:main Nov 1, 2021
@cloudxxx8 cloudxxx8 deleted the issue-3768 branch January 31, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metadata] No dependency check for support-notifications on startup
3 participants