Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): Correct metadata default config #617

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Oct 31, 2021

Change Notifications.PostDeviceChanges default value to false, and
correct to Notifications related config default value to meet the
current v2 design on Core Metadata page.

Signed-off-by: Cloud Tsai [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

@cloudxxx8 cloudxxx8 changed the title fix(microservices):Correct metadata default config fix(microservices): Correct metadata default config Oct 31, 2021
Change Notifications.PostDeviceChanges default value to false, and
correct to Notifications related config default value to meet the
current v2 design on Core Metadata page.

Signed-off-by: Cloud Tsai <[email protected]>
@cloudxxx8
Copy link
Member Author

cloudxxx8 commented Oct 31, 2021

related change: edgexfoundry/edgex-go#3789

@lenny-goodell lenny-goodell linked an issue Nov 1, 2021 that may be closed by this pull request
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit c4c28d0 into edgexfoundry:main Nov 1, 2021
edgex-jenkins added a commit that referenced this pull request Nov 1, 2021
@cloudxxx8 cloudxxx8 deleted the issue-616 branch November 8, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default PostDeviceChanges to false in Core Metadata
2 participants