Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] Get Binary Reading from database hasn't been implemented #3286

Closed
cloudxxx8 opened this issue Mar 23, 2021 · 3 comments · Fixed by #3303
Closed

[V2] Get Binary Reading from database hasn't been implemented #3286

cloudxxx8 opened this issue Mar 23, 2021 · 3 comments · Fixed by #3303
Assignees
@weichou1229
Labels
2-medium priority denoting issues with cross-cutting project impact enhancement New feature or request ireland

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package

This feature request is for core-data

Description

The Binary Reading conversion hasn't been implemented in the infrastructure layer

edgex-go/internal/pkg/v2/infrastructure/redis/reading.go

Lines 235 to 236 in bf41993

// as V2 APi doesn't deal with BinaryReading at this moment, convert to SimpleReading here
// Shall update the logic here when working on BinaryReading in the future

@cloudxxx8 cloudxxx8 added enhancement New feature or request 2-medium priority denoting issues with cross-cutting project impact ireland labels Mar 23, 2021
@cloudxxx8
Copy link
Member Author

@jinlinGuan for awareness. we should test the Binary Reading creation and query from core-data API

@lenny-goodell
Copy link
Member

@cloudxxx8, @jinlinGuan, Note that Binary Reading values are not stored in the database, so expectation is the actual value will be empty, but reading properties are present.

@cloudxxx8
Copy link
Member Author

right, but we should be able to retrieve the mediaType

@weichou1229 weichou1229 mentioned this issue Mar 26, 2021
Merged
6 tasks
lenny-goodell pushed a commit that referenced this issue Mar 29, 2021
@weichou1229
feat(data): Implement get Binary Reading from database (#3303)
d1fc594 
Use alias struct to extract ValueType and convert to specified reading

Close #3286

Signed-off-by: weichou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weichou1229 weichou1229

Labels
2-medium priority denoting issues with cross-cutting project impact enhancement New feature or request ireland
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(data): Implement get Binary Reading from database
3 participants
@weichou1229 @cloudxxx8 @lenny-goodell