Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yaml.v3 library instead of yaml.v2 #3060

Closed
cloudxxx8 opened this issue Jan 21, 2021 · 2 comments
Closed

Use yaml.v3 library instead of yaml.v2 #3060

cloudxxx8 opened this issue Jan 21, 2021 · 2 comments
Assignees
@weichou1229
Labels
1-low priority denoting isolated changes enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package

This feature request is for core-metadata

Description

We have a dependency using yaml.v3 and our code is using yaml.v2, so we have both library in our build.
We should use only one of them.
@cloudxxx8 cloudxxx8 added enhancement New feature or request 1-low priority denoting isolated changes ireland labels Jan 21, 2021
@weichou1229 weichou1229 mentioned this issue Jan 22, 2021
Closed
weichou1229 added a commit to weichou1229/go-mod-core-contracts that referenced this issue Jan 22, 2021
@weichou1229
build: Upgrade yaml library to v3
283b2cf 
Upgrade yaml library to v3 to consist with the edgex-go edgexfoundry/edgex-go#3060

Close edgexfoundry#452

Signed-off-by: weichou <[email protected]>
This was referenced Jan 22, 2021
Closed
Closed
@cloudxxx8
Copy link
Member Author

hold this issue until yaml v3 is official released

@cloudxxx8 cloudxxx8 added hold Intended for PRs we want to flag for ongoing review and removed ireland labels Jan 25, 2021
@cloudxxx8 cloudxxx8 removed the hold Intended for PRs we want to flag for ongoing review label Aug 27, 2021
@cloudxxx8
Copy link
Member Author

fixed by #3683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weichou1229 weichou1229

Labels
1-low priority denoting isolated changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Use yaml.v3 library instead of yaml.v2
2 participants
@weichou1229 @cloudxxx8