Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update Security example to 3.1.0 released images. #240

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

lenny-goodell
Copy link
Member

Removed obsolte compose files and fixed doc link in README.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

Removed obsolte compose files and fixed doc  link in README.

Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell added this to the Napa milestone Nov 15, 2023
@bnevis-i
Copy link
Collaborator

Removed obsolte compose files and fixed doc link in README.

Would you be open to publishing a large context diff instead? I wanted to show what the specific changes where to enable this functionality.

@lenny-goodell
Copy link
Member Author

Would you be open to publishing a large context diff instead?

Not following what you are looking for?

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i
Copy link
Collaborator

Would you be open to publishing a large context diff instead?

Not following what you are looking for?

diff -c 10 original-docker-compose.yaml new-docker-compose.yaml > docker-compose.diff

and check in docker-compose.diff

The idea is to show people how to recreate the supplied docker-compose.

@lenny-goodell
Copy link
Member Author

The idea is to show people how to recreate the supplied docker-compose.

As part of the tutorial? Not sure the value and it is out of scope for this PR.

Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waive review.

@lenny-goodell lenny-goodell merged commit 77e0359 into edgexfoundry:main Nov 15, 2023
1 check passed
@lenny-goodell lenny-goodell deleted the security-examples branch November 15, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants