fix: fixing remote spire agent docker file to resolve build issues #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnevis-i
approved these changes
Sep 26, 2023
bnevis-i
previously approved these changes
Sep 26, 2023
vyshali-chitikeshi
force-pushed
the
fix-remote-spire-agent-docker-file
branch
from
29b18f3 to
cc16aaf
Compare
|
Updated docker file as per review comments, validated with device usb service. able to build remote spire agent successfully and device usb service started successfully on remote node |
bnevis-i
previously approved these changes
Sep 26, 2023
lenny-goodell
requested changes
Sep 26, 2023
security/remote_devices/spiffe_and_ssh/remote/remote-spire-agent/Dockerfile
Outdated
Show resolved
Hide resolved
security/remote_devices/spiffe_and_ssh/remote/remote-spire-agent/Dockerfile
Outdated
Show resolved
Hide resolved
vyshali-chitikeshi
force-pushed
the
fix-remote-spire-agent-docker-file
branch
from
cc16aaf to
dcdd284
Compare
Signed-off-by: vyshali-chitikeshi <[email protected]>
vyshali-chitikeshi
force-pushed
the
fix-remote-spire-agent-docker-file
branch
from
dcdd284 to
f963bce
Compare
|
@bnevis-i without arg for Builder base, it builds successfully and device service started. |
bnevis-i
approved these changes
Sep 26, 2023
Ok. If it fails in CI we can always put it back. |
No CI on this repo... ;-) |
lenny-goodell
pushed a commit
to lenny-goodell/edgex-examples
that referenced
this pull request
Nov 14, 2023
Signed-off-by: vyshali-chitikeshi <[email protected]> Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell
pushed a commit
to lenny-goodell/edgex-examples
that referenced
this pull request
Nov 14, 2023
Signed-off-by: vyshali-chitikeshi <[email protected]> Signed-off-by: Leonard Goodell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
Testing Instructions