Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove docs #231

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Conversation

ChristianDarr-personal
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A

Testing Instructions

Copy link
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to remove the docs under web-ui too after migrating.

@ajcasagrande
Copy link

ajcasagrande commented Jun 9, 2023

Have to remove the docs under web-ui too after migrating.

Actually I do not think that the web-ui docs are supposed to be moved and removed. they are for development purposes only I believe, so makes sense to live in the repo.

Signed-off-by: Darr, Christian <[email protected]>
Signed-off-by: Darr, Christian <[email protected]>
Copy link
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@presatish presatish merged commit d399815 into edgexfoundry:main Jun 13, 2023
@presatish presatish deleted the remove-docs branch June 13, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants