feat: Update latest images tags to 3.0.0 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docker-compose examples to use image tags 3.0.0 instead of latest Closes: edgexfoundry#228 Signed-off-by: Jim Wang <[email protected]>
bnevis-i
previously requested changes
Jun 2, 2023
security/remote_devices/spiffe_and_ssh/remote/docker-compose.yml
Outdated
Show resolved
Hide resolved
ok, i can revert those back but then you have to keep track of version from this to the next release? So for example, the previous one would be renamed to something like docker-compose.2.x or something like that |
bnevis-i
dismissed
their stale review
Dismissing review... Lenny to take responsiblity.
Signed-off-by: Jim Wang <[email protected]>
bnevis-i
previously approved these changes
Jun 2, 2023
lenny-goodell
requested changes
Jun 5, 2023
security/remote_devices/spiffe_and_ssh/remote/docker-compose.yml
Outdated
Show resolved
Hide resolved
…nd makefile Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
There was a problem hiding this comment.
LGTM, need 2nd review from Camera team since changing their example app
@presatish , @ajcasagrande , please review change from docker-compose to docker compose in Camera Mgmt app.
lenny-goodell
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docker-compose examples to use image tags 3.0.0 instead of latest
Closes: #228
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
Testing Instructions