fix: camera mgmt docker build, secret names, and go mods #229
Conversation
- Fixed the docker build for Camera Management App and make it work with docker compose. - Fixed the naming inconsistencies with secrets in the yaml file and code. Now also matches rtspauth from the device-usb-camera service. - Removed errors package from go.mod, to use EdgeX errors package, to match the device services. Signed-off-by: Anthony Casagrande <[email protected]>
|
Valediction looks good in non-secure mode. Tested with ONVIF and USB cameras. |
| @@ -14,17 +14,39 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| version: "3" | |||
| version: '3.7' | |||
There was a problem hiding this comment.
Probably not that important but the newest version is 3.8 right?
There was a problem hiding this comment.
Ok I looked into this more and seems like you kept this in sync with other edgex compose files.
There was a problem hiding this comment.
Not important.
Version 3.8
An upgrade of version 3 that introduces new parameters. It is only available with Docker Engine version 19.03.0 and higher.
Introduces the following additional parameters:
max_replicas_per_node in placement configurations
template_driver option for config and secret configurations. This option is only supported when deploying swarm services using docker stack deploy.
driver and driver_opts option for secret configurations. This option is only supported when deploying swarm services using docker stack deploy.
There was a problem hiding this comment.
The version field is actually deprecated and merely informative now.
| } | ||
| } | ||
| if err != nil { | ||
| app.lc.Errorf("Unable to query EVAM pipeline statuses after %d tries. .") |
There was a problem hiding this comment.
You need to put in the value of i for this error message.
There was a problem hiding this comment.
Also there is an extra period in the message.
Signed-off-by: Anthony Casagrande <[email protected]>
| # Run the app. | ||
| make run-app | ||
| # Start the docker compose services in the background for both EVAM and Camera Management App | ||
| docker compose up -d |
There was a problem hiding this comment.
Since all other commands are make commands it would be nice to also have docker compose ones under make.
There was a problem hiding this comment.
normally I would agree, but in this case I think it is fine to keep as docker compose, as the user has more control over it
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
Testing Instructions