Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Helm updates to device-coap and device-bacnet for v3 C SDK #226

Merged
merged 1 commit into from
May 31, 2023
Merged

feat: Helm updates to device-coap and device-bacnet for v3 C SDK #226

merged 1 commit into from
May 31, 2023

Conversation

bnevis-i
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

@bnevis-i bnevis-i added this to the Minnesota milestone May 31, 2023
@bnevis-i bnevis-i requested a review from lenny-goodell May 31, 2023 22:22
lenny-goodell
lenny-goodell approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit fa11870 into edgexfoundry:main May 31, 2023
@bnevis-i bnevis-i deleted the c-sdk-fixes branch May 31, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Minnesota
Development

Successfully merging this pull request may close these issues.
2 participants
@bnevis-i @lenny-goodell