-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: device events #197
feat: device events #197
Conversation
Signed-off-by: brianointel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Just a few more tweaks needed.
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/appcamera/evam.go
Outdated
Show resolved
Hide resolved
application-services/custom/camera-management/res/configuration.toml
Outdated
Show resolved
Hide resolved
Signed-off-by: Brian Osburn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -37,7 +37,7 @@ ARG MAKE="make build-app" | |||
RUN $MAKE | |||
|
|||
#final stage | |||
FROM alpine:3.15 | |||
FROM alpine:3.16 | |||
LABEL license='SPDX-License-Identifier: Apache-2.0' \ | |||
copyright='Copyright (c) 2022: Intel' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright='Copyright (c) 2022: Intel' | |
copyright='Copyright (c) 2023: Intel' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@presatish , missed this one in your last commit. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lenny-intel I purposefully didn't update it as I was not completely sure if that had to be changed :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@presatish , we typical do update it when we update the one for the file.
Signed-off-by: preethi-satishcandra <[email protected]>
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
Testing Instructions