Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: device events #197

Merged

Conversation

brianointel
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

Signed-off-by: brianointel <[email protected]>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few more tweaks needed.

Signed-off-by: Brian Osburn <[email protected]>
lenny-goodell
lenny-goodell previously approved these changes May 9, 2023
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -37,7 +37,7 @@ ARG MAKE="make build-app"
RUN $MAKE

#final stage
FROM alpine:3.15
FROM alpine:3.16
LABEL license='SPDX-License-Identifier: Apache-2.0' \
copyright='Copyright (c) 2022: Intel'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copyright='Copyright (c) 2022: Intel'
copyright='Copyright (c) 2023: Intel'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@presatish , missed this one in your last commit. ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenny-intel I purposefully didn't update it as I was not completely sure if that had to be changed :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@presatish , we typical do update it when we update the one for the file.

Signed-off-by: preethi-satishcandra <[email protected]>
@ajcasagrande ajcasagrande merged commit e60111e into edgexfoundry:main May 17, 2023
@ajcasagrande ajcasagrande deleted the usb_device_events_pr branch May 17, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Mgmt Example - Auto start EVAM on new camera devices
4 participants