feat: Helm chart updates for minnesota #187

bnevis-i · 2023-03-24T18:19:50Z

List of changes:

Brought README up-to-date
Added support for authenticated pulls (to dockerhub)
Added core-common-config microservice
Brought command lines and environment variables up-to-date with EdgeX 3.0 docker-compose changes
Added missing data volumes
Created YAML values files to specify tip and releasee versions of containers
Fixed bug in eKuiper volume initialization
Repairs to ingress rules for port matching
Documentation to obtain authentication JWT

PR Checklist

Please check if your PR fulfills the following requirements:

I have added unit tests for the new feature or bug fix (if not, why?)
I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

Command to launch everything in distributed mode with security enabled:

helm install edgex-minnesota  -n edgex --values development-images-values-x86_64.yaml --set imagePullSecrets="{ dockerhub }" --set edgex.features.messagebusbackend=mqtt --set edgex.security.enabled=true --set edgex.storage.useHostPath=false --set edgex.storage.nonSharedVolumesClassName=ceph-block --set edgex.storage.sharedVolumesClassName=ceph-filesystem  --values runall.yaml .

Where the edgex namespace already exists and the "dockerhub" image pull secret is generated according to the README.md.
If only have a single node storage cluster omit useHostPath=false and don't override the storageclass names.

The contents of runall.yaml is:

edgex:

  # replicas defines the number of replicas in a Deployment for the respective application
  replicas:
    core:
      common_config: 1
      command: 1
      data: 1
      metadata: 1
    support:
      notifications: 1
      scheduler: 1
    appservice:
      rules: 1
      mqttexport: 1
      httpexport: 1
      appsample: 1
      metricsinfluxdb: 1
      rfidllrpinventory: 1
      externalmqtttrigger: 1
    device:
      virtual: 1
      rest: 1
      usbcamera: 1
      onvifcamera: 1
      mqtt: 1
      modbus: 1
      bacnet: 1
      coap: 1
      snmp: 1
      rfidllrp: 1
      gpio: 1
    ui: 1
    system: 1
    consul: 1
    redis: 1
    ekuiper: 1
    modbussimulator: 1
    mqttbroker: 1
    natsserver: 1

Expect that edgex-device-bacnet and edgex-device-coap will fail to launch.

jim-wang-intel · 2023-04-24T21:25:49Z

deployment/helm/README.md

 - [Helm](https://helm.sh/) 3.7.0+

-## Installation
+Before starting, make sure you have curl and openssl installed locally.
+These tools are need to generate TLS assets and test the configuration.


Suggested change

These tools are need to generate TLS assets and test the configuration.

These tools are needed to generate TLS assets and test the configuration.

jim-wang-intel · 2023-04-24T21:28:01Z

deployment/helm/README.md

+
+The example also arbitrarily configures the ingress route to
+respond to the hostname `edgex` 
+(which should be passed using the TLS Server Name Identification (SNI) feature).


Suggested change

(which should be passed using the TLS Server Name Identification (SNI) feature).

(which should be passed in using the TLS Server Name Identification (SNI) feature).

jim-wang-intel · 2023-04-24T21:45:49Z

deployment/helm/README.md

+*** 
+TODO get an JWT from Helm
+***


details to be filled in?

This was a big hole. I had to make a lot of changes. No wonder I hadn't submitted PR review earlier. This has been updated.

List of changes: - Brought README up-to-date - Added support for authenticated pulls (to dockerhub) - Added core-common-config microservice - Brought command lines and environment variables up-to-date with EdgeX 3.0 docker-compose changes - Added missing data volumes - Created YAML values files to specify tip and releasee versions of containers - Fixed bug in eKuiper volume initialization - Repairs to ingress rules for port matching - Documentation to obtain authentication JWT Signed-off-by: Bryon Nevis <[email protected]>

jim-wang-intel

LGTM

* feat: Helm chart updates for minnesota (#187) List of changes: - Brought README up-to-date - Added support for authenticated pulls (to dockerhub) - Added core-common-config microservice - Brought command lines and environment variables up-to-date with EdgeX 3.0 docker-compose changes - Added missing data volumes - Created YAML values files to specify tip and releasee versions of containers - Fixed bug in eKuiper volume initialization - Repairs to ingress rules for port matching - Documentation to obtain authentication JWT Signed-off-by: Bryon Nevis <[email protected]> * feat: Upgrade all simple App Service examples to V3 (#193) Signed-off-by: Leonard Goodell <[email protected]> * feat: Upgrade all advanced App Service examples to V3 (#195) Signed-off-by: Leonard Goodell <[email protected]> * feat: Upgrade ibm-mqtt-export configurable example to V3 (#196) Signed-off-by: Leonard Goodell <[email protected]> * refactor: Consume MakeItRun rename to Run (#198) * feat: Upgrade ibm-mqtt-export configurable example to V3 Signed-off-by: Leonard Goodell <[email protected]> * refactor: Upgade cloud-event app service to use V3 (#200) Signed-off-by: Marc-Philippe Fuller <[email protected]> * fix: device-usb-camera to use the correct start up docker-entrypoint shell script (#207) The device USB camera uses different executable like docker-entrypoint shell script for bootstrapper so update it for this case. Signed-off-by: Jim Wang <[email protected]> * refactor: Upgrade json-logic app service to use V3 (#206) * refactor: Upgrade json-logic app service to use V3 closes: #194 Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade influx-export to use V3 (#205) * refactor: Upgrade influx-export to use V3 Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade custom-trigger-nats-rpc to use V3 (#203) Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade fledge-export to use V3 (#204) * refactor: Upgrade fledge-export to use V3 Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade cloud-export-mqtt to use V3 (#201) Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade custom_trigger app service to use V3 (#202) Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade send-command to use V3 (#209) * refactor: Upgrade send-command to use V3 Signed-off-by: Marc-Philippe Fuller <[email protected]> * refactor: Upgrade secrets to use V3 (#208) * refactor: Upgrade secrets to use V3 Signed-off-by: Marc-Philippe Fuller <[email protected]> * fix: Address missed V3 migration of InsecureSecrets (#210) Signed-off-by: Leonard Goodell <[email protected]> * feat: Remove random device and grove-c from example and update README (#212) Closes: issue #211 Signed-off-by: Valina Li <[email protected]> * feat: Update Camera Management example on minnesota-dev branch (#213) * feat: Update Camera Managment exmaple on minnesota-dev branch This is to sync minnesota-dev with latest on main prior to migrating it to V3 Signed-off-by: Leonard Goodell <[email protected]> * fix: Change v2 API references to v3 (#215) Signed-off-by: Leonard Goodell <[email protected]> * feat: Migrate Camera Management example to V3 (#214) * feat: Migrate Camera Management example to V3 closes #194 Signed-off-by: Leonard Goodell <[email protected]> Signed-off-by: Anthony Casagrande <[email protected]> Signed-off-by: preethi-satishcandra <[email protected]> Co-authored-by: Anthony Casagrande <[email protected]> Co-authored-by: preethi-satishcandra <[email protected]> * build: Update app service examples to released SDK (#218) Signed-off-by: Leonard Goodell <[email protected]> * feat: Remove obsolete deployment templates (#219) These were for the EdgeX ready program and never used/updated for new releases. Signed-off-by: Leonard Goodell <[email protected]> * feat: Update to 3.0.0 images in helm values.yaml (#220) Signed-off-by: Bryon Nevis <[email protected]> --------- Signed-off-by: Bryon Nevis <[email protected]> Signed-off-by: Leonard Goodell <[email protected]> Signed-off-by: Marc-Philippe Fuller <[email protected]> Signed-off-by: Jim Wang <[email protected]> Signed-off-by: Valina Li <[email protected]> Signed-off-by: Anthony Casagrande <[email protected]> Signed-off-by: preethi-satishcandra <[email protected]> Co-authored-by: Bryon Nevis <[email protected]> Co-authored-by: Marc-Philippe Fuller <[email protected]> Co-authored-by: Jim Wang @ Intel <[email protected]> Co-authored-by: Valina Li <[email protected]> Co-authored-by: Anthony Casagrande <[email protected]> Co-authored-by: preethi-satishcandra <[email protected]>

bnevis-i added this to the Minnesota milestone Mar 24, 2023

bnevis-i linked an issue Mar 24, 2023 that may be closed by this pull request

helm deployment: Minnesota release updates #186

Closed

bnevis-i changed the title ~~feat: Helm chart updates for minnesota~~ feat: Helm chart updates for minnesota (WIP) Mar 24, 2023

lenny-goodell linked an issue Mar 27, 2023 that may be closed by this pull request

[Helm] Add Core Common Config Bootstrapper to to example Helm Chart #179

Closed

bnevis-i marked this pull request as ready for review April 18, 2023 17:00

bnevis-i changed the title ~~feat: Helm chart updates for minnesota (WIP)~~ feat: Helm chart updates for minnesota Apr 18, 2023

This was referenced Apr 18, 2023

device-coap failing with HTTP 409 Conflict message in secure mode edgexfoundry/device-coap-c#45

Closed

device-bacnet failing with HTTP 409 Conflict message edgexfoundry/device-bacnet-c#74

Closed

bnevis-i requested a review from jim-wang-intel April 24, 2023 19:31

jim-wang-intel reviewed Apr 24, 2023

View reviewed changes

bnevis-i marked this pull request as draft April 25, 2023 01:39

bnevis-i marked this pull request as ready for review April 25, 2023 18:48

bnevis-i requested a review from jim-wang-intel April 25, 2023 18:48

jim-wang-intel approved these changes Apr 25, 2023

View reviewed changes

bnevis-i merged commit c8ce8ca into edgexfoundry:minnesota-dev Apr 25, 2023

bnevis-i deleted the minnesota-updates branch April 25, 2023 21:34

lenny-goodell mentioned this pull request May 30, 2023

helm deployment: Minnesota release updates #186

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Helm chart updates for minnesota #187

feat: Helm chart updates for minnesota #187

bnevis-i commented Mar 24, 2023 •

edited

Loading

jim-wang-intel Apr 24, 2023

bnevis-i Apr 25, 2023

jim-wang-intel Apr 24, 2023

bnevis-i Apr 25, 2023

jim-wang-intel Apr 24, 2023

bnevis-i Apr 25, 2023

jim-wang-intel left a comment

	These tools are need to generate TLS assets and test the configuration.
	These tools are needed to generate TLS assets and test the configuration.

	(which should be passed using the TLS Server Name Identification (SNI) feature).
	(which should be passed in using the TLS Server Name Identification (SNI) feature).

feat: Helm chart updates for minnesota #187

feat: Helm chart updates for minnesota #187

Conversation

bnevis-i commented Mar 24, 2023 • edited Loading

PR Checklist

Testing Instructions

jim-wang-intel Apr 24, 2023

Choose a reason for hiding this comment

bnevis-i Apr 25, 2023

Choose a reason for hiding this comment

jim-wang-intel Apr 24, 2023

Choose a reason for hiding this comment

bnevis-i Apr 25, 2023

Choose a reason for hiding this comment

jim-wang-intel Apr 24, 2023

Choose a reason for hiding this comment

bnevis-i Apr 25, 2023

Choose a reason for hiding this comment

jim-wang-intel left a comment

Choose a reason for hiding this comment

bnevis-i commented Mar 24, 2023 •

edited

Loading